Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exp): update security documentation #273

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

keirthana
Copy link
Collaborator

Documentation changes

This PR updates our security documentation with details about how we store user data.

Review and preview

Have you reviewed and previewed your documentation updates?
Yes, the linkchecker fails because of an issue with jwt.io which is an issue on their side rather than a broken link. So for this PR, it has to be treated as a non-blocking check.

Reviewers

Make sure to get at least one review from the Anbox team.

JIRA / Launchpad bug

AC-3069

@keirthana keirthana requested a review from a team as a code owner January 22, 2025 16:33
@keirthana keirthana requested a review from morphis January 22, 2025 16:34
@keirthana keirthana force-pushed the update-security-docs branch from c6b2518 to cb8fd5a Compare January 28, 2025 06:50
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirthana keirthana force-pushed the update-security-docs branch from cb8fd5a to 7ddfece Compare January 28, 2025 08:56
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That reads a bit nicer, LGTM!

Copy link
Contributor

@jat-canonical jat-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small correction.

explanation/anbox-security.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. One suggestion on how we can back link to the crypto docs

explanation/anbox-security.md Show resolved Hide resolved
@keirthana keirthana requested a review from morphis January 29, 2025 17:16
Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keirthana keirthana merged commit 9f6cdb9 into canonical:main Jan 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants