-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exp): update security documentation #273
Conversation
c6b2518
to
cb8fd5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
cb8fd5a
to
7ddfece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That reads a bit nicer, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One small correction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. One suggestion on how we can back link to the crypto docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Documentation changes
This PR updates our security documentation with details about how we store user data.
Review and preview
Have you reviewed and previewed your documentation updates?
Yes, the linkchecker fails because of an issue with jwt.io which is an issue on their side rather than a broken link. So for this PR, it has to be treated as a non-blocking check.
Reviewers
Make sure to get at least one review from the Anbox team.
JIRA / Launchpad bug
AC-3069