-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aar): add instructions to use instance profiles with AAR #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you though add a link to the release notes for 1.21 so we can get that linked for people interested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions and I see that Simon has already suggested adding the link to RN
5dbf10e
to
4596873
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@morphis Are you fine with the current changes? Can I go ahead and merge+publish this update? |
@keirthana if we get a link into 1.21 release notes, then I am fine. However that seems to be still missing from the PR. |
@morphis I think there is some confusion here about whether you want the link from the doc to the RN or the reverse. In your most latest comment, you say "into the RN" , so I think it is the way we usually do - from the RN to the docs. Correct? |
@morphis could you confirm ? |
We need to link from the RN to the docs. |
4596873
to
4e60777
Compare
This commit adds the instructions to make use of the newly added support for instance profiles in AAR.
4e60777
to
33f6fa1
Compare
Since the pending comment has been addressed, I am merging and publishing this PR. |
This commit adds the instructions to make use of the newly added support for instance profiles in AAR.