Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aar): add instructions to use instance profiles with AAR #37

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

jat-canonical
Copy link
Contributor

This commit adds the instructions to make use of the newly added support for instance profiles in AAR.

Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you though add a link to the release notes for 1.21 so we can get that linked for people interested?

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions and I see that Simon has already suggested adding the link to RN

howto/aar/deploy.md Outdated Show resolved Hide resolved
howto/aar/deploy.md Outdated Show resolved Hide resolved
howto/aar/deploy.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keirthana
Copy link
Collaborator

@morphis Are you fine with the current changes? Can I go ahead and merge+publish this update?

@morphis
Copy link
Collaborator

morphis commented Feb 15, 2024

@keirthana if we get a link into 1.21 release notes, then I am fine. However that seems to be still missing from the PR.

@jat-canonical
Copy link
Contributor Author

@morphis They have been added here. Let me know if it needs changes.

@keirthana
Copy link
Collaborator

@morphis I think there is some confusion here about whether you want the link from the doc to the RN or the reverse. In your most latest comment, you say "into the RN" , so I think it is the way we usually do - from the RN to the docs. Correct?

@jat-canonical
Copy link
Contributor Author

@morphis could you confirm ?

@morphis
Copy link
Collaborator

morphis commented Feb 20, 2024

@morphis I think there is some confusion here about whether you want the link from the doc to the RN or the reverse. In your most latest comment, you say "into the RN" , so I think it is the way we usually do - from the RN to the docs. Correct?

We need to link from the RN to the docs.

This commit adds the instructions to make use of the newly added support
for instance profiles in AAR.
@keirthana
Copy link
Collaborator

Since the pending comment has been addressed, I am merging and publishing this PR.

@keirthana keirthana merged commit b1d6539 into canonical:main Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants