Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): add section to cover stream attach support #51

Merged
merged 2 commits into from
May 15, 2024

Conversation

morphis
Copy link
Collaborator

@morphis morphis commented Mar 22, 2024

No description provided.

@morphis morphis requested a review from keirthana March 22, 2024 21:07
howto/instance/create.md Outdated Show resolved Hide resolved
howto/instance/create.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

howto/instance/create.md Outdated Show resolved Hide resolved
howto/instance/create.md Outdated Show resolved Hide resolved
howto/instance/create.md Outdated Show resolved Hide resolved
howto/instance/create.md Outdated Show resolved Hide resolved
@keirthana keirthana added this to the 1.23.0 milestone Mar 26, 2024
@morphis morphis requested review from keirthana and ajanon March 26, 2024 08:38
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@adglkh adglkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

howto/instance/create.md Show resolved Hide resolved
@morphis morphis modified the milestones: 1.23.0, 1.22.0 Mar 27, 2024
reference/ams-configuration.md Outdated Show resolved Hide resolved
@morphis morphis force-pushed the add-stream-attach branch from 50263c6 to a9e9fea Compare April 5, 2024 04:49
Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the versioning in the previous review

howto/instance/create.md Outdated Show resolved Hide resolved
@keirthana keirthana merged commit f2d5de4 into canonical:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants