Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instance-type with resources in example manifests #77

Merged
merged 2 commits into from
May 30, 2024

Conversation

keirthana
Copy link
Collaborator

Since instance-type is deprecated, it is a good idea to use resources in our examples to lead by example.
I have removed some obvious places where it is a straight-forward replacement but have not done the replacements in outputs to maintain technical accuracy (we still list instance type in outputs for backwards compatibility).

@keirthana keirthana requested a review from adglkh May 24, 2024 13:53
howto/application/test.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keirthana keirthana merged commit d21a753 into canonical:main May 30, 2024
3 checks passed
@keirthana keirthana deleted the fix-instance-type branch July 3, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants