Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD: Add format for instance.network_proxy #93

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ajanon
Copy link
Contributor

@ajanon ajanon commented Jul 15, 2024

This adds the format for the value of instance.network_proxy.

Fixes https://bugs.launchpad.net/anbox-cloud/+bug/2072510

This adds the format for the value of instance.network_proxy.
@ajanon ajanon force-pushed the fix_network_proxy branch from 675aa11 to 919a3b6 Compare July 15, 2024 07:18
@ajanon ajanon requested a review from keirthana July 15, 2024 07:19
@ajanon ajanon changed the title feat(reference): add format for instance.network_proxy RTD: Add format for instance.network_proxy Jul 15, 2024
@ajanon
Copy link
Contributor Author

ajanon commented Jul 15, 2024

The link health check is failing, but I'm not sure what I should do about it.

@keirthana
Copy link
Collaborator

The link health check is failing, but I'm not sure what I should do about it.

If it is not failing due to any links that you added (which is the case with this PR), please ignore it. I need to watch the checker for a few weeks to see if it is really worth having it enabled despite the random breaks.

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajanon ajanon merged commit 1977aac into canonical:main Jul 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants