Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding BtLE Advertisements #96

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Adding BtLE Advertisements #96

merged 1 commit into from
Jun 10, 2024

Conversation

RossComputerGuy
Copy link
Contributor

Fixes #85 & #40

This PR adds support for advertisements.

@github-actions GitHub Actions
Copy link

Hey! RossComputerGuy has not signed the Canonical CLA which is required to get this contribution merged on this project.

Please head over to https://ubuntu.com/legal/contributors to read more about it.

@RossComputerGuy RossComputerGuy marked this pull request as ready for review May 26, 2024 05:16
@RossComputerGuy
Copy link
Contributor Author 

Unhandled exception:
org.bluez.Error.Failed: Failed to parse advertisement.
#0      _BlueZObject.callMethod (package:bluez/src/bluez_client.dart:1202:11)
<asynchronous suspension>
#1      BlueZAdvertisingManager.registerAdvertisement (package:bluez/src/bluez_client.dart:359:5)
<asynchronous suspension>
#2      main (file:///home/ross/MidstallSoftware/contrib/bluez.dart/example/advertisement.dart:34:3)
<asynchronous suspension>

Dang, I know I am close.

@RossComputerGuy RossComputerGuy force-pushed the feat/le-advert branch 2 times, most recently from 575947b to 255ae99 Compare May 26, 2024 22:36
@RossComputerGuy
Copy link
Contributor Author

Okay, why is this CLA check not passing? I've signed it half a dozen times.

@RossComputerGuy
Copy link
Contributor Author

Ok, this appears to be working now.

@RossComputerGuy
Copy link
Contributor Author

Added the unregisterAdvertisement function. Fully ready and working.

@robert-ancell
Copy link
Contributor

Okay, why is this CLA check not passing? I've signed it half a dozen times.

There'll be a delay with the system updating, thanks!

robert-ancell
robert-ancell requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think with the requested changes this should be good.

@RossComputerGuy RossComputerGuy force-pushed the feat/le-advert branch 4 times, most recently from 9ec688d to 99555d0 Compare May 28, 2024 03:48
robert-ancell
robert-ancell requested changes May 30, 2024
View reviewed changes
robert-ancell
robert-ancell approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks!

@robert-ancell robert-ancell merged commit 4ccb328 into canonical:main Jun 10, 2024
4 of 5 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/le-advert branch June 10, 2024 00:33
@RossComputerGuy RossComputerGuy mentioned this pull request Jun 10, 2024
Open
@rohitsangwan01 rohitsangwan01 mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-ancell robert-ancell robert-ancell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use bluez to act as bluetooth peripheral
2 participants
@RossComputerGuy @robert-ancell