Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu-images extension #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

waveform80
Copy link
Member

Split out from the ubuntu-boards-documentation. Tests included as doctest. To run, from a venv with the extensions installed:

python3 -m doctest canonical-sphinx-extensions/ubuntu-images/__init__.py

Being doctest, no output and zero exit code means tests have passed. If you have coverage installed:

coverage run -m doctest canonical-sphinx-extensions/ubuntu-image/__init__.py
coverage report

P.S. Please let me split up the README on the front of the repo :)

And is too dumb to deal with data associated with a class being closely
spaced next to the class
pylint picked this up ... flake8 didn't
@waveform80
Copy link
Member Author

flake8's still complaining about line-lengths, but most of these are either:

  • difficult to correct (e.g. doctest expected output which includes intentional whitespace and formatting)
  • simple to correct but doing so would obscure the intention (the test case generating the release file)
  • not worth correcting (e.g. one or two characters over and splitting the line would make it less readable)

Personally I'd recommend just disabling the E501 test (or weakening it considerably). Actually I'd recommend switching the test to pylint (which tends to pick up more useful stuff and has much more descriptive and flexible disable comments), but that would probably be more painful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant