[WIP]: add optional pre_run test config to allow running interface tests on uv/poetry/monorepo charms #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsgruk
force-pushed
the
feat/remote_repo_venv_setup
branch
from
55af89b to
14ef580
Compare
jnsgruk
requested changes
Feb 10, 2025
I meant to open this as draft, sorry. WIP still |
PietroPasotti
changed the title
jnsgruk
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all charms come with a requirements.txt file.
For those who don't, this feature adds a configurable pre-test-run step that gives the interface test configurator a chance to run a bash script to generate a requirements.txt file.
Fixes #216
For monorepo charms, added a charm_root test config option that allows you to run interface tests on charms that don't live at the root of their repo.
Fixes #219
To make this less OP, we could also consider a more 'targeted' approach and specifically target uv and poetry to set things up.
Tandem pr: canonical/pytest-interface-tester#29