Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Small tweaks in the prepare stages #223

Merged
merged 4 commits into from
Feb 13, 2025
Merged

WIP Small tweaks in the prepare stages #223

merged 4 commits into from
Feb 13, 2025

Conversation

tonyandrewmeyer
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer commented Feb 12, 2025 •
edited
Loading

  • I feel like subprocess.run would be a simpler choice than using Popen directly - and also it seems very unlikely that there could be any other error than the process failing (although I should check if the timeout raises CalledProcessError or something else) - also fixes what is I think a bug where {error} should be {e} and there's an unnecessary str()
  • Very nit-y stuff on getting the charm root path.

PietroPasotti
PietroPasotti reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the thought, some thoughts back:

run_matrix.py Outdated Show resolved Hide resolved
run_matrix.py Outdated Show resolved Hide resolved
@tonyandrewmeyer tonyandrewmeyer marked this pull request as ready for review February 13, 2025 02:30
PietroPasotti
PietroPasotti approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tonyandrewmeyer tonyandrewmeyer merged commit eeceac3 into canonical:main Feb 13, 2025
6 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the pre-run-tweaks branch February 13, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti PietroPasotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyandrewmeyer @PietroPasotti