Core24 builds action (infra) (#1215)

* General Fixes

Use artifact name that is unique per matrix
Use v4 instead of v3 upload action
Set group and label to avoid TF runners as well
Select also tag to not use TF runners
Wrong copy pasted matrix variable
Remove alegedly outdated workaroud

* Use for cycle to clear exestack

* Updated hack workaroud logging found and without envvar

.github/workflows/core24-builds.yml

@@ -9,7 +9,6 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        type: [classic, uc]
         releases: [24]
         arch: [amd64, arm64]
         tag: [X64, ARM64]
@@ -19,6 +18,8 @@ jobs:
           - arch: arm64
             tag: X64
     runs-on:
+      group: "Canonical self-hosted runners"
+      labels:
         - self-hosted
         - linux
         - jammy
@@ -54,7 +55,7 @@ jobs:
           with: |
             path: checkbox-core-snap/series${{ matrix.releases }}
             snapcraft-channel: 7.x/stable
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: Upload logs on failure
         if: failure()
         with:
@@ -63,10 +64,10 @@ jobs:
             /home/runner/.cache/snapcraft/log/
             /home/runner/.local/state/snapcraft/log/
             checkbox-core-snap/series${{ matrix.releases }}/checkbox*.txt
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: Upload the snap as artifact
         with:
-          name: series${{ matrix.releases }}
+          name: checkbox${{ matrix.releases }}_${{ matrix.arch }}
           path: checkbox-core-snap/series${{ matrix.releases }}/*.snap
       - uses: Wandalen/wretry.action@a163f62ae554a8f3cbe27b23db15b60c0ae2e93c # v1.3.0
         name: Upload the snap to the store

checkbox-core-snap/series24/snap/snapcraft.yaml

@@ -222,14 +222,16 @@ parts:
       python3 manage.py build
       python3 manage.py install --layout=relocatable --prefix=/providers/checkbox-provider-base --root="$CRAFT_PART_INSTALL"
     override-prime: |
-      craftctl default
       # needed because else this will trigger the store autoreviewer and be autorejected
       # cleaning this bit should not cause any issue but if it does do not only remove this line
       # contact also the store/update the package because else this will always trigger
       # a manual review
-      [ -f usr/lib/x86_64-linux-gnu/libamdhip64.so.5.2.* ] && execstack --clear-execstack usr/lib/x86_64-linux-gnu/libamdhip64.so.5.2.* || true
+      for libamd_path in $(find .. -name "libamdhip64.so.5*"); do
+        echo "Clearing execstack on $libamd_path";
+        execstack --clear-execstack "$libamd_path" || exit 1
+      done;
+      craftctl default
     stage-packages:
-      - execstack # needed to clear the execstack
       - python3-opencv
       - bc
       - bonnie++
@@ -306,6 +308,7 @@ parts:
       - on arm64:
         - python3-rpi.gpio # only in focal
     build-packages:
+      - execstack # needed to clear the execstack
       - libasound2-dev
       - libcap-dev
     organize: