-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor WIFI STAs resource job and Support Wifi 7 (New) #1175
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
+ Coverage 43.19% 43.26% +0.06%
==========================================
Files 356 357 +1
Lines 38653 38700 +47
Branches 6561 6571 +10
==========================================
+ Hits 16697 16742 +45
- Misses 21293 21294 +1
- Partials 663 664 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b749e08
to
40a5997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seankingyang, please see my inline comments.
f42683d
to
3c9c503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Issac,
Sorry for jumping. But, Do you think we can add information about interface mode support then we can replace id: wifi_interface_mode
as well?
As per-discussed in the meeting. This requirement will be divided into different PR later on. |
Seperate the support WIFI 7 (BE) test cases in next PR #1224 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only one major comment, see if it makes sense, everything else is basically some small refactoring that makes it slightly easier to read in my opinion, take it or leave it
e69ef84
to
471f92e
Compare
471f92e
to
d30898e
Compare
This was updated, it now satisfies the review
Description
This PR just refactor the resource shell cmd to python script, and make it can identiry if the DUT support the following condition:
Ideally, we should know which bands (2.4Hz, 5Hz, 6GHz) do the DUT support, I add this function to this script too.
Resolved issues
Documentation
Tests
slide load on checkbox deb version
wireless_sta_protocol
RTL8821CE:
AX211:
BE200 on jammy:
BE200 on noble
QCNFA765 support 6GHz:
Run Desktop auto test plan (client-cert-desktop-22-04-automated)
only select the wireless category
202201-29926 QCN765 only support up to AC
202402-33474 BE200 in noble support up to BE