Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created launchers for 24.04 Release (New) #1200

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Created launchers for 24.04 Release (New) #1200

merged 1 commit into from
Apr 19, 2024

Conversation

bladernr
Copy link
Collaborator

Description

Add new launchers for 24.04 release for Server Cert. New launchers and test plans are now version agnostic. The older 22.04 specific launchers and testplans will remain for a while and will eventually be deprecated in the future.

Going forward users will use commands like certify-ubuntu-server rather than certify-24.04

Resolved issues

SERVCERT-1538

Documentation

Will need minor updats to self-test guide which are already underway (CDOC-42)

Tests

Simply diffed the 22.04 launchers and testplans that these were copied from and verified the new testplan IDs matched. No further tests needed

…rd and will deprecate older version launchers in the future (e.g. certify-22.04 style launchers will be deprecated in favor of a single version agnostic launcher called certify-ubuntu-server SERVCERT-1538
@bladernr bladernr changed the title Created launchers for 24.04 Release. Created launchers for 24.04 Release (Feature) Apr 19, 2024
@bladernr bladernr changed the title Created launchers for 24.04 Release (Feature) Created launchers for 24.04 Release (New) Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.21%. Comparing base (e1f796b) to head (5886713).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   43.21%   43.21%           
=======================================
  Files         356      356           
  Lines       38662    38662           
  Branches     6561     6561           
=======================================
  Hits        16706    16706           
  Misses      21293    21293           
  Partials      663      663           
Flag Coverage Δ
provider-certification-server 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@kissiel kissiel merged commit 84878c2 into main Apr 19, 2024
13 of 15 checks passed
@kissiel kissiel deleted the 24.04-launchers branch April 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants