Checkbox snap for Core24 builds (infra) #1201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces the core24 snapcraft.yaml. The snaps for arm64 and amd64 are already in the store and were built from this recipe. To aid the review of this huge PR, just know that most of the content here is copy-pasted from core22 so for an easier review I can reccomend
Here is a full description of what changed:
SNAPCRAFT...
environment variable was renamed intoCRAFT...
as per the new snapcraft guidelinesnapcraft pull/build/stage
etc. explicit action (in overrides) replaced withcraft default
as per new snapcraft guidelineThe snap contains a small hack (documented above it) to clear the exestack bit on one library
libamdhip64.so.5.2
for amd64. This is necessary as the snap will require a manual review on every build if it is not done. The change doesn't seem to have any impact and should be removable once the library is updated.Resolved issues
N/A
Documentation
From a documentation point of view the only change from series22 is the exestack bit clearing, that is documented.
Tests
Snaps were built and are currently in the store.