Fall back from distutils -> packaging.version (bugfix) #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 43.21% 43.32% +0.11%
==========================================
Files 356 356
Lines 38662 38658 -4
Branches 6561 6559 -2
==========================================
+ Hits 16706 16750 +44
+ Misses 21293 21245 -48
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Minor: black formatting
Hook25
force-pushed
the
fix_distuils_gone
branch
from
db46de6 to
cb9dbd5
Compare
kissiel
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Distutils is no longer available in python3.12. With this PR when distutils is not available, we fall back to packaging.version.
Resolved issues
Fixes: #1193
Documentation
N/A
Tests
N/A