Update possible certification status values for Job units and modify its default (new) #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the default was "unspecified". Set it to "non-blocker". In addition, remove both "unspecified" and "non-part-of-certification" statuses, since one is redundant and the other has never been used in practice. Fix CER-2586
Since there are only two possible certification statuses now, remove tests that are not required anymore.
Until now, jobs with an "unspecified" certification status would not show any certification status in the HTML report. Since "non-blocker" becomes the default, the same behavior is applied. Therefore, only jobs with a "blocker" certification status will specify their certification status. "non-blocker" is assumed for all the others.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
+ Coverage 43.21% 43.37% +0.16%
==========================================
Files 356 356
Lines 38662 38660 -2
Branches 6561 6561
==========================================
+ Hits 16706 16768 +62
+ Misses 21293 21213 -80
- Partials 663 679 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pieqq
force-pushed
the
CER-2586-two-cert-status-only
branch
from
3694b31 to
427414a
Compare
Hook25
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
+1 on the change, less random statusses for jobs is better! A few questions, the most important one is: this doesn't change anything in the remote codebase (as far as I can see). Is this change propagated there somehow I can't understand right now? If so, how?
Minor other questions below.
checkbox-ng/plainbox/test-data/html-exporter/with_both_certification_status.html
Show resolved
Hide resolved
checkbox-ng/plainbox/test-data/html-exporter/with_certification_non_blocker.html
Show resolved
Hide resolved
fernando79513
added
the
waiting-for-changes
pieqq
changed the title
pieqq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now, a Job unit could have 4 possible values for certification status (
unspecified,not-part-of-certification,blocker,non-blocker). This PR reduces the number to 2 (blockerandnon-blocker), and set the default tonon-blocker(instead ofunspecifiedin the past).Resolved issues
CER-2586
Documentation
unspecifiedcertification values are updated throughout the docsTests
The
disk-cert-automatednested part has a mix of default and cert-blockers.Running
checkbox-cli list-bootstrapped -f "{id} ({certification_status})\n" "com.canonical.certification::disk-cert-automated"allows to see the difference before and after the patch.Before:
After:
I also ran this test plan before and after the patch and uploaded the results to C3.
Before:
After: