Fix base provider's unit tests (BugFix) #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 43.32% 43.36% +0.03%
==========================================
Files 356 357 +1
Lines 38658 38684 +26
Branches 6559 6560 +1
==========================================
+ Hits 16750 16775 +25
Misses 21245 21245
- Partials 663 664 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
approved these changes
Apr 30, 2024
kissiel
force-pushed
the
fix-base-provider-tests
branch
from
6af64a5 to
74d05f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over the course of last 2 months, yet again, tests that calling
sleepor other unmocked time-related functions had been committed to the repository making the iteration time unnecessary long.One of the test also made the whole thing unable to be run from within editors or IDEs that are running from a snap, because it actually asserted we're not running from snap (and of course the CI let it through, as it runs the tests not within a snap.
Overall this PR makes the tests run 20x faster.
See individual commits for details.