Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TiCS CI (Infra) #1490

Merged
merged 19 commits into from
Oct 11, 2024
Merged

Add TiCS CI (Infra) #1490

merged 19 commits into from
Oct 11, 2024

Conversation

douglasdotc
Copy link
Contributor

@douglasdotc douglasdotc commented Sep 19, 2024 •
edited
Loading

Description

This PR adds TiCS GitHub Action to Checkbox.

Resolved issues

CHECKBOX-1560

Documentation

Tests

See GHA

@douglasdotc
Add TiCS CI.
1467438 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Change branch name for testing.
ba20163 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc douglasdotc marked this pull request as ready for review September 19, 2024 18:16
@douglasdotc
Copy link
Contributor Author

douglasdotc commented Sep 19, 2024 •
edited
Loading

The TiCS GHA step alone can run > 1.5h. I am wondering if we should really let this CI runs per push to main.
Should we just run this daily/weekly/release or other frequencies?

@douglasdotc
Turn to a cron job on main.
a4f9d55 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Fix dependencies for pytest.
a35e799 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Fix format.
c073aac 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Add dependency for TiCS.
3fb9ea7 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Fix dependency installation
67fa03c 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Add sound dependency.
fe90930 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Add dependency.
eedee47 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Add dependency.
56906ef 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Add PIL dependency...
2099e68 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
cron job
2cde17b 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc douglasdotc changed the title Add TiCS CI (New) Add TiCS CI (Infra) Oct 2, 2024
Hook25
Hook25 requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if the following make sense

.github/workflows/checkbox-tics.yml Outdated Show resolved Hide resolved
.github/workflows/checkbox-tics.yml Outdated Show resolved Hide resolved
.github/workflows/checkbox-tics.yml Outdated Show resolved Hide resolved
.github/workflows/checkbox-tics.yml Outdated Show resolved Hide resolved
@douglasdotc
Fix path
a3103e9 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Turn back to cron job
40adf18 
Signed-off-by: Douglas Chiang <[email protected]>
@douglasdotc
Copy link
Contributor Author

PR ready for another review, thanks. @Hook25

@Hook25 Hook25 merged commit b4050b9 into main Oct 11, 2024
7 checks passed
@Hook25 Hook25 deleted the add-checkbox-tiobe branch October 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hook25 Hook25 Hook25 approved these changes

@jocave jocave Awaiting requested review from jocave

@fernando79513 fernando79513 Awaiting requested review from fernando79513

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglasdotc @Hook25