Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement V4L2 compliance parser (New) #1569

Merged
merged 22 commits into from
Dec 6, 2024
Merged

Implement V4L2 compliance parser (New) #1569

merged 22 commits into from
Dec 6, 2024

Conversation

tomli380576
Copy link
Contributor

@tomli380576 tomli380576 commented Oct 31, 2024

Description

This PR implements a V4L2 compliance test parser in checkbox support for test cases to validate that the ioctl requests they need to use are actually supported.

Requires #1566

Resolved issues

Documentation

Test cases can from checkbox_support.parsers.v4l2_compliance import parse_v4l2_compliance and call the function for a device, such as parse_v4l2_compliance('/dev/video0')

Tests

Unit tests

@tomli380576 tomli380576 force-pushed the v4l2-compliance-parser branch from da66a9d to 8bf354d Compare October 31, 2024 15:42
@tomli380576 tomli380576 force-pushed the v4l2-compliance-parser branch from 8bf354d to c001bcb Compare October 31, 2024 15:45
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.05%. Comparing base (7b5dd02) to head (1005470).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
...upport/checkbox_support/parsers/v4l2_compliance.py 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
+ Coverage   48.00%   48.05%   +0.04%     
==========================================
  Files         371      371              
  Lines       39833    39872      +39     
  Branches     6730     6738       +8     
==========================================
+ Hits        19121    19159      +38     
- Misses      19994    19995       +1     
  Partials      718      718              
Flag Coverage Δ
checkbox-support 60.99% <97.43%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomli380576 tomli380576 marked this pull request as ready for review November 14, 2024 06:00
@fernando79513 fernando79513 self-assigned this Nov 18, 2024
@pieqq pieqq assigned Hook25 and unassigned fernando79513 Nov 29, 2024
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here, sorry it took me a while to review it. Consider my comments below, the only one that is blocking is the one about pkg_resource, because soon it will go away, and when it does I will have to patch half of checkbox to add the workaroud I suggested.

@tomli380576 tomli380576 requested a review from Hook25 December 6, 2024 02:20
Hook25
Hook25 previously approved these changes Dec 6, 2024
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see if the following makes sense to you

@Hook25 Hook25 merged commit 1938d60 into main Dec 6, 2024
41 checks passed
@Hook25 Hook25 deleted the v4l2-compliance-parser branch December 6, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants