Move jobs to dedicated external provider (New) #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-gentili
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
==========================================
+ Coverage 47.88% 47.91% +0.03%
==========================================
Files 371 367 -4
Lines 39820 39537 -283
Branches 6731 6698 -33
==========================================
- Hits 19066 18943 -123
+ Misses 20042 19886 -156
+ Partials 712 708 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
p-gentili
changed the title
p-gentili
force-pushed
the
so-long-zapper
branch
from
b2424c0 to
6a1a45e
Compare
p-gentili
force-pushed
the
so-long-zapper
branch
from
013c572 to
1c97387
Compare
Hook25
approved these changes
Nov 25, 2024
eugene-yujinwu
pushed a commit
to eugene-yujinwu/checkbox
that referenced
this pull request
Dec 31, 2024
* Change: so long zapper * Change: moved desktop_session to resource provider * Change: remove explicit Zapper support from run_watcher * Add: unit tests for removable_storage_watcher::main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This modifies com.canonical.certification::sru
Description
This is probably Breaking instead of New, but I don't think it's necessary to bump that major version. Your call.
This PR gets rid of every Zapper-driven job, moving to a dedicated external provider.
Also, a bit of refactor to the storage_watcher class was required, happy to change direction if that doesn't work for you.
Resolved issues
Part of ZAP-1002
Documentation
N/A
Tests
Only the storage watcher test case is impacted by this PR. It's a manual test.