proviers/base: add requires for bluetooth4/beacon_eddystone_url_* (New) #1646
Conversation
In order to pass, the test bluetooth4/beacon_eddystone_url_* needs: - bluez package/snap (+ adequate connections for ubuntu core)
hector-cao
changed the title
| requires: | ||
| package.name == 'bluez' or snap.name == 'bluez' |
There was a problem hiding this comment.
If you use this statement, and the bluez snap/package is missing, the test will be skipped, which might be even harder to spot if this test was supposed to be executed to begin with.
Is this what you want to do?
There was a problem hiding this comment.
Thanks @pieqq,
- I see this statement is used for other tests in this jobs file, that is why I had the idea to do the same for this test
- You are right about the fact that we have to check all the skipped tests to make sure that are skipped for good reason, but without this statement, I also had a hard time to figure out that this test failed because
bluezwas missing, i have the feeling that it is a global discussion we might have because expressing dependency of a test on a binary availability is very common in our existing tests, so your concern is somehow global and not applicable to only this PR,
There was a problem hiding this comment.
Maybe also having a fail-on-resource flag in this job will get what you want
… bluez is not installed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 370 370
Lines 40234 40234
Branches 6794 6794
=======================================
Hits 19657 19657
Misses 19857 19857
Partials 720 720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
In order to pass, the test bluetooth4/beacon_eddystone_url_* needs:
This PR add
requiressection to the test bluetooth4/beacon_eddystone_url_*Resolved issues
During Intel IOTG certification test run, we bumped into this test failure for server classic image,
It took us some time to realize that the bluez package is missing, this time spent can be saved with this
requiressectionDocumentation
N/A
Tests
The test runs successfully on 22.04 server image