Hidden manifests implementation (new) #1699
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor: also update old test that is now failing on python3.13+
This is not a solid way to set the default value that is now migrated to the collect-manifest job
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
==========================================
+ Coverage 49.01% 49.12% +0.10%
==========================================
Files 372 372
Lines 40348 40338 -10
Branches 6817 6809 -8
==========================================
+ Hits 19777 19816 +39
+ Misses 19849 19799 -50
- Partials 722 723 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Minor: Move default value calculation to the manifest unit
Hook25
force-pushed
the
hidden_manifests
branch
from
cffcfed to
0d3e1b9
Compare
Hook25
force-pushed
the
hidden_manifests
branch
from
0d3e1b9 to
1e5ef3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need a “hidden” manifest type to be able to include/exclude jobs runs in the lab without impact normal end user experience:
Hidden = not available for general consumption, not shown in the Manifest entries screen
hidden keyword raises questions, so need an additional hidden_reason field to explain why this manifest is not shown to the user (e.g. “No OBEX server testing required in the HW Cert lab”)
These manifest entries must be false (i.e. not set) for submissions made to issue a Certificate (Cert issuance process must include this check, this is a critical violation because it can lead to important things not being tested)
Hidden manifest IDs must start with _ (underscore). This is for easier reading/parsing/debugging, and must have a hidden-reason field to explain why they were introduced.
Resolved issues
Fixes: CHECKBOX-1698
Documentation
WIP
Tests
WIP