Added camera quality test using brisque (New) #759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 34.83% 34.92% +0.08%
==========================================
Files 302 303 +1
Lines 34165 34211 +46
Branches 5909 5918 +9
==========================================
+ Hits 11903 11949 +46
Misses 21697 21697
Partials 565 565
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fernando79513
changed the title
fernando79513
force-pushed
the
CHECKBOX-456/webcam-signal-test
branch
from
8cc0b39 to
d65b611
Compare
yphus
reviewed
Oct 12, 2023
| @@ -68,6 +69,7 @@ _description: Camera tests After Suspend (automated) | |||
| include: | |||
| after-suspend-camera/detect certification-status=blocker | |||
| after-suspend-camera/multiple-resolution-images_.* certification-status=blocker | |||
| camera/camera-quality_* certification-status=non-blocker | |||
There was a problem hiding this comment.
Prefix our job with after-suspend- here. This version of your checkbox camera job is automatically instantiated if the flag after-suspend- is used
There was a problem hiding this comment.
I have added the after-suspend flag
fernando79513
force-pushed
the
CHECKBOX-456/webcam-signal-test
branch
11 times, most recently
from
f4c459c to
f743854
Compare
fernando79513
force-pushed
the
CHECKBOX-456/webcam-signal-test
branch
5 times, most recently
from
4cc892d to
56d7da6
Compare
Added modified version of the brisque algorithm in chechkbox_support/vendor. The algorithm is implemented in: https://github.com/rehanguha/brisque Vendorized also python-libsvm to fix imports in snap
New camera quality test using brisque algorithm included in "camera-cert-automated"
Included some automated tests to the image quality test to increase the coverage
…indings Nota: Only for 22.04 (until the syntax allows >= 22.04)
fernando79513
force-pushed
the
CHECKBOX-456/webcam-signal-test
branch
from
56d7da6 to
9a9b79c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to have in place a basic test to check if the webcam signal is properly retrieved by the camera. The idea is to use an implementation of the BRISQUE algorithm to assess if the quality of the image is adequate and if we don't have issues with the decoding.
Resolved issues
Resolves "https://warthogs.atlassian.net/browse/CHECKBOX-456"
Documentation
So far, this PR does not include any changes in the documentation
Tests
The test is included in the
Camera tests (automated). Alternatively, you can run the Python script underproviders/base/bin/calledcamera_quality_test.py