-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add realtime performance test (New) #925
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 41.64% 41.72% +0.07%
==========================================
Files 340 341 +1
Lines 37748 37795 +47
Branches 6419 6426 +7
==========================================
+ Hits 15722 15769 +47
Misses 21378 21378
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8b98d3a
to
38b6414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on the script and the associated unit tests!
Two little suggestions (you can apply them directly from GitHub) and one question.
@pieqq Please review it again when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the packaging metadata and snapcraft.yaml addition as discussed in my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Packaging bits look good, just one thing to add back into the script.
Co-authored-by: Pierre Equoy <[email protected]>
Co-authored-by: Pierre Equoy <[email protected]>
6f21985
to
6b30454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks!
* Add realtime performance test * Add rt-tests into stage-packages for series22 * Add packaging.pxu for rt-tests --------- Co-authored-by: Pierre Equoy <[email protected]>
Description
I move the realtime performance test from checkbox-iiotg-provider to the checkbox monorepo.
Resolved issues
N/A
Documentation
N/A
Tests
I run testplan
rt-performance-tests-full
or you can sayRealtime Peformance Tests (Full)
on EHL (202306-31656).submission: https://certification.canonical.com/hardware/202306-31656/submission/351345/