-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix udevadm.py to parser VRAID partition correctly (Bugfix) #952
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
==========================================
+ Coverage 41.64% 41.74% +0.09%
==========================================
Files 340 340
Lines 37748 37769 +21
Branches 6419 6422 +3
==========================================
+ Hits 15722 15768 +46
+ Misses 21378 21352 -26
- Partials 648 649 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I have verified this fixed on an IoT platform, which has Intel RST RAID enabled. And we could get the disk info by udev_resource.py scripts without errors.
Test results:
|
e170579
to
11c801e
Compare
11c801e
to
295ee5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could checkbox-support/checkbox_support/parsers/tests/udevadm_data/With_VRAID.txt
be reduced to contain only the parts that are interesting?
16kLOC takes quite a while to parse, it's also a burden for the repo. I know we've committed files like that in the past, but we definitely need to stop.
Minimize the input data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for making the test run in a reasonable time!
+1
…l#952) * Fix for VRAID * Add the unit test data * Reduce the input data size
Description
The DUT with VRAID, the udevadm.py could not parser the right thing.
Push this PR could fix this bug.
Resolved issues
#482 udev_resource.py -f PARTITION failed with error
Documentation
Tests