Update contruct to v2.10.57 (bugfix) #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the module get mechanism to be backward compatible with python3.4
- Modify the size calculator to be compatible with python3.4 ('e' not
supported)
Minor: whitespaces
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
=======================================
Coverage 39.18% 39.18%
=======================================
Files 315 315
Lines 34899 34899
Branches 5972 5972
=======================================
Hits 13676 13676
Misses 20610 20610
Partials 613 613
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kissiel
approved these changes
Jan 22, 2024
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Updated to 2.10.57
- Modify the module get mechanism to be backward compatible with python3.4
- Modify the size calculator to be compatible with python3.4 ('e' not
supported)
* Updated to 2.10.57
Minor: whitespaces
* Updated to 2.10.57
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Updated to 2.10.57
- Modify the module get mechanism to be backward compatible with python3.4
- Modify the size calculator to be compatible with python3.4 ('e' not
supported)
* Updated to 2.10.57
Minor: whitespaces
* Updated to 2.10.57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The vendorized version of contruct uses the now removed (as of python3.12)
impmodule. This PR updates the vendorized module to a more up-to-date version of construct with the following changes:supportshalffloatsamong other functions (used in python3.5 that doesn't support the structeformatter)Resolved issues
Partially solves: https://launchpadlibrarian.net/710488943/buildlog_ubuntu-noble-amd64.checkbox-support_3.3.0~dev96~ubuntu24.04.1_BUILDING.txt.gz
Documentation
This PR documentation and the commit messages should be enough to document what was done
Tests
N/A