Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown function in tests for checkbox-support (bugfix) #958

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jan 22, 2024

Description

When running via the deb runner, this test fails on python 3.12. This should always fail and the reason why it doesn't is still unclear to me at this point. The function name is wrong and it should be assert_called_once_with

This updates every test with the correct function call.

Resolved issues

Resolves: https://launchpadlibrarian.net/710488943/buildlog_ubuntu-noble-amd64.checkbox-support_3.3.0~dev96~ubuntu24.04.1_BUILDING.txt.gz

Documentation

N/A

Tests

N/A

@Hook25 Hook25 changed the title Fixed unknown method name in checkbox-support test (bugfix) Fix unknown function in tests for checkbox-support (bugfix) Jan 22, 2024
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, +1
(I wonder if toxxing will choke on it or not)

@kissiel kissiel merged commit 7a6cb78 into main Jan 22, 2024
3 checks passed
@kissiel kissiel deleted the fix_snap_utils_tests branch January 22, 2024 13:10
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
…l#958)

* Fixed unknown method name in checkbox-support test

* Called once with counts before filtering
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
…l#958)

* Fixed unknown method name in checkbox-support test

* Called once with counts before filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants