Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(24.04): missing lib64 in base-files #154

Merged

Conversation

cjdcordeiro
Copy link
Collaborator

fixes #153

/lib64 is now in base-files, so this PR includes said paths in its libs slice.

@norrisjeremy
Copy link

Thanks!

@norrisjeremy
Copy link

FYI, I believe /lib64 is owned by the libc6 package, not base-files.
That is what shows up when I run dpkg -S /lib64 on a regular 24.04 container.
I think that's why your CI builds fail.

@norrisjeremy
Copy link

$ docker run -it --rm ubuntu:24.04 dpkg -S /lib64  
libc6:amd64: /lib64

@norrisjeremy
Copy link

diff --git a/slices/libc6.yaml b/slices/libc6.yaml
index 5f67118..fcd25b4 100644
--- a/slices/libc6.yaml
+++ b/slices/libc6.yaml
@@ -28,3 +28,4 @@ slices:
       /usr/lib/*-linux-*/libthread_db.so.*:
       /usr/lib/*-linux-*/libutil.so.*:
       /usr/lib*/ld*.so.*:
+      /lib64: {arch: [amd64,ppc64el]}

@cjdcordeiro
Copy link
Collaborator Author

The errors are coming from the fact that /lib64 isn't present for all architectures in base-files.

Noble is a development release and thus changing all the time. We'll take this internally to double check where /lib64 is eventually landing and whether it should belong to base-files or libc6. The symlink definition, according to dpkg -c, is currently under base-files.

# dpkg -c base-files_13ubuntu7_amd64.deb | grep lib64
drwxr-xr-x root/root         0 2024-02-22 14:39 ./usr/lib64/
lrwxrwxrwx root/root         0 2024-02-22 14:39 ./lib64 -> usr/lib64

But this could be changing as we speak so let's wait for the upstream to finish updating.

@norrisjeremy
Copy link

Apologies for earlier reply, I misread your response.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cjdcordeiro cjdcordeiro requested a review from letFunny February 28, 2024 15:49
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjdcordeiro cjdcordeiro merged commit bc7afa4 into canonical:ubuntu-24.04 Feb 29, 2024
8 checks passed
@cjdcordeiro cjdcordeiro deleted the 24.04-fix-base-files-lib64 branch February 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants