-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add copyright slices for libgcc-s1 and libstdc++6 #168
feat(24.04): add copyright slices for libgcc-s1 and libstdc++6 #168
Conversation
Hi Jeremy. Let's first try to get this PR in. Once it does, backporting should be easy. I will let @cjdcordeiro take a look whenever he gets some free time. This PR may need some discussion since we haven't explicitly added copyright files previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
We are just finalizing an internal discussion about the handling of copyright files that may impact this PR, thus why its merging may be taking a bit longer. For now, it seems to be in the right direction but I'll review it once we've converged internally |
Ok, thanks for the update! |
Diff of dependencies: |
@cjdcordeiro @rebornplusplus What's the hold-up on getting this merged? It's been languishing for over a month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @norrisjeremy .
I'm leaving just a couple of comments here, but once those are in and the linting is passing, this should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, danke! I added the pending changes. Sorry about the delay on this.
The CLA check is failing now. @norrisjeremy, you may need to sign the CLA form with proper email address.
I've already signed the CLA, and you have already merged other PRs I submitted. |
…d libstdc++6 slices to ensure copyright file is included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have manually confirmed the CLA compliance, so let's follow up on the CLA action offline and merge the PR as is for now
thanks for the contribution
Can confirm there may be an issue with the CLA check. Sorry about that. |
Proposed changes
fix(24.04): add gcc-14-base slice and make essential for libgcc-s1 and libstdc++6 slices to ensure copyright file is included
Related issues/PRs
#156
Forward porting
Testing
Checklist
Additional Context