Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add gzip #331

Open
wants to merge 8 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

Meulengracht
Copy link
Member

@Meulengracht Meulengracht commented Sep 3, 2024

Proposed changes

Propose tools gzip and tar. I did not propose tar alone, as tar invokes gzip as the underlying compression tool.

Forward porting

#483

Checklist

Copy link

github-actions bot commented Sep 3, 2024

Diff of dependencies:

slices/coreutils.yaml
@@ -1,6 +1,8 @@
 libacl1
 libattr1
 libc6
+libcrypt1
+libgcc-s1
 libgmp10
+libpcre2-8-0
 libselinux1
-libssl3t64
slices/gzip.yaml
@@ -1,3 +1,9 @@
-dpkg
-install-info
+base-files
+bash
+coreutils
+diffutils
+grep
+less
 libc6
+sed
+util-linux
slices/util-linux.yaml
@@ -1,8 +1,11 @@
+base-files
 libblkid1
 libc6
 libcap-ng0
 libcrypt1
 libmount1
+libpam-modules
+libpam-runtime
 libpam0g
 libselinux1
 libsmartcols1

@Meulengracht Meulengracht changed the title slices: add gzip and tar feat(24.04): add gzip and tar Sep 3, 2024
slices/tar.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Meulengracht can you pls rebase :)

@Meulengracht Meulengracht changed the title feat(24.04): add gzip and tar feat(24.04): add gzip Oct 2, 2024
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(some additional tests needed - discussed offline)

Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the missing tests, this looks good to me.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you!

@rebornplusplus rebornplusplus requested a review from a team February 3, 2025 05:16
@zhijie-yang zhijie-yang added the forward port missing The forward port is missing. label Feb 3, 2025
@eunufe eunufe mentioned this pull request Feb 4, 2025
3 tasks
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many binaries not tested. Besides, we should remove the systems: directive in the yaml, since ppc64le and s390x are not tested by spread anyways.

tests/spread/integration/gzip/task.yaml Outdated Show resolved Hide resolved
@zhijie-yang zhijie-yang removed the forward port missing The forward port is missing. label Feb 5, 2025
@zhijie-yang zhijie-yang mentioned this pull request Feb 5, 2025
3 tasks
@norrisjeremy
Copy link

Hi @zhijie-yang,

Are you & Canonical working to bring slices for gzip to 24.04 and 24.10?

Thanks!
Jeremy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants