feat(24.10): forward-port SDF for tar #492
Conversation
|
Diff of dependencies: |
| - tar_rmt | ||
| - tar_tar | ||
| contents: | ||
| /usr/sbin/tarcat: |
There was a problem hiding this comment.
tarcat will actually need dash and coreutils (only dd, tr, cut).
There was a problem hiding this comment.
The tar package doesn't declare dependencies on dash & coreutils, so not sure I understand why the SDF would declare them?
There was a problem hiding this comment.
Agreed.
@norrisjeremy some packages won't declare dependencies to other packages that are deemed "essential" and always present on the distro.
tarcat is a shell script #!/bin/sh that runs commands such as dd cat cut tr...
there's no test for it, and there should be one. that would support this statement. And the 24.04 should be fixed as well
| - tar_copyright | ||
|
|
||
| slices: | ||
| bins: |
There was a problem hiding this comment.
Let's have bins contain all the binaries. We can have individual slices rmt, tar, cat etc. and then include all of those in bins.
There was a problem hiding this comment.
That would diverge from the existing SDF in 24.04 that this is a forward-port of?
There was a problem hiding this comment.
this is already the case.
tar's binaries aretarcat,rmt-tarandtar. The latter two are brought in viaessential. So effectivelybinscontains all binaries , as doestarin 24.04
| essential: | ||
| - libc6_libs | ||
| contents: | ||
| /etc/rmt: {symlink: /usr/sbin/rmt-tar} |
There was a problem hiding this comment.
lrwxrwxrwx root/root 0 2024-04-08 16:20 ./etc/rmt -> /usr/sbin/rmt
I see that /etc/rmt points to /usr/sbin/rmt. The latter is created via the postinst script.
update-alternatives --install /usr/sbin/rmt rmt /usr/sbin/rmt-tar 50 \
--slave /usr/share/man/man8/rmt.8.gz rmt.8.gz \
/usr/share/man/man8/rmt-tar.8.gzIn my opinion, let's honour that chain.
| /etc/rmt: {symlink: /usr/sbin/rmt-tar} | |
| /etc/rmt: | |
| /usr/sbin/rmt: {symlink: /usr/sbin/rmt-tar} |
Let me know what you think.
There was a problem hiding this comment.
@rebornplusplus This is a forward-port of the existing tar SDF definition from 24.04 that is missing in 24.10.
Not sure I understand why we would make changes that cause it to diverge from what was landed originally in #320?
There was a problem hiding this comment.
Yep, agreed @rebornplusplus
@norrisjeremy is it something we should fix in 24.04.
There was a problem hiding this comment.
yep.
please add the tarcat test too so we cover the use case discussed in the comments above.
eunufe
changed the title
| - tar_copyright | ||
|
|
||
| slices: | ||
| bins: |
There was a problem hiding this comment.
this is already the case.
tar's binaries aretarcat,rmt-tarandtar. The latter two are brought in viaessential. So effectivelybinscontains all binaries , as doestarin 24.04
| - tar_rmt | ||
| - tar_tar | ||
| contents: | ||
| /usr/sbin/tarcat: |
There was a problem hiding this comment.
Agreed.
@norrisjeremy some packages won't declare dependencies to other packages that are deemed "essential" and always present on the distro.
tarcat is a shell script #!/bin/sh that runs commands such as dd cat cut tr...
there's no test for it, and there should be one. that would support this statement. And the 24.04 should be fixed as well
| essential: | ||
| - libc6_libs | ||
| contents: | ||
| /etc/rmt: {symlink: /usr/sbin/rmt-tar} |
There was a problem hiding this comment.
Yep, agreed @rebornplusplus
@norrisjeremy is it something we should fix in 24.04.
There was a problem hiding this comment.
yep.
please add the tarcat test too so we cover the use case discussed in the comments above.
|
FYI #498 |
|
@cjdcordeiro @rebornplusplus I'm not sure I understand what is being asked here? |
|
we'll take care of #498 @norrisjeremy , which addressed 24.04. This PR (24.10), needs some fixing. If you cannot make those, that's fair, just let us know, and we should be able to pick it up at some point, as long as we have maintainer access to change the PR. |
@cjdcordeiro We are disappointed that a simple copy/paste forward port of an existing SDF cannot simply be merged, especially since we did not author the original one. |
|
I understand the frustration. please understand that we want to keep improving things, and thus it would be counter-productive to forward port something that is inherently flawed. The fact that the 24.04's SDF needs fixing is of course not your fault, and we'll be taking care of fixing it. The same for this PR, if you decide to focus on other slices - we'll take care of it :). |
Proposed changes
feat(24.10): forward-port SDF for tar
Related issues/PRs
Forward porting
#320
Checklist
Additional Context