Adding PagerDuty Native support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstathis
reviewed
May 30, 2024
IbraAoad
requested review from
Abuelodelanada,
lucabello,
PietroPasotti,
sed-i,
simskij and
mmkay
as code owners
dstathis
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #61
Raised pagerduty alerts are not using dedupication key to correlating triggers and resolves.
Causing a new alerts to be trigered every interval and alerts are never resolved
Solution
Native PagerDuty support is added to cos-alerter via the PD python client pdpyras
Context
Currently we're depending on Apprise to send notifications to destinations for when an alertmanager instance is down, Apprise currently has no support for adding dedup key to the PagerDuty incident
Testing Instructions
1- Deploy cos-alerter and add a Pagerduty valid connection string
pagerduty://{integration_key}@{api_key}to cos-alerter list of destinations2- PagerDuty incidents should be grouped per an Alertmanager client if it's down
3- Once the Alertmanager client is up again the PD incident should be self-resolved