Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(completion): use an app_config if present #323

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix(completion): use an app_config if present #323

merged 4 commits into from
Jan 23, 2025

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Jan 22, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Fixes an issue when using the completion generator with craft tools based on craft-application.

CRAFT-3994

@bepri bepri self-assigned this Jan 22, 2025
@bepri
Copy link
Contributor Author

bepri commented Jan 22, 2025

With this branch I'm able to successfully use the newer craft-application based Snapcraft dispatcher: canonical/snapcraft#5208

@bepri bepri marked this pull request as ready for review January 22, 2025 21:07
@bepri bepri requested review from tigarmo and lengau January 22, 2025 21:07
lengau
lengau approved these changes Jan 22, 2025
View reviewed changes
craft_cli/completion/completion.py Show resolved Hide resolved
tigarmo
tigarmo requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turnaround on this

craft_cli/completion/completion.py Outdated Show resolved Hide resolved
craft_cli/completion/completion.py Outdated Show resolved Hide resolved
tests/integration/test_completion.py Outdated Show resolved Hide resolved
@bepri bepri requested a review from tigarmo January 23, 2025 13:31
tigarmo
tigarmo approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bepri bepri merged commit 9d3c155 into main Jan 23, 2025
11 checks passed
@bepri bepri deleted the work/tab-completion-fix/CRAFT-3994 branch January 23, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@lengau lengau lengau approved these changes

Assignees

@bepri bepri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bepri @tigarmo @lengau