Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy juju env support #152

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Add proxy juju env support #152

merged 1 commit into from
Dec 6, 2023

Conversation

nrobinaubertin
Copy link
Collaborator

@nrobinaubertin nrobinaubertin commented Dec 4, 2023

Overview

Add support for juju-http(s)-proxy model-config settings.
This populates the http_proxy, no_proxy environment variables for all pebble operations.

Checklist

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Test coverage for ab366c4

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        325     31     82     11    90%   137, 171, 179-180, 336->341, 535-537, 542-543, 554-556, 561-562, 574-576, 581-582, 594-596, 621-623, 663->exit, 673->exit, 703-709, 735->exit, 749-750, 760->exit, 774
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               355     32     90     12    90%

Static code analysis report

Run started:2023-12-04 16:02:47.959044

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1946
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@nrobinaubertin nrobinaubertin marked this pull request as ready for review December 5, 2023 19:55
@nrobinaubertin nrobinaubertin requested a review from a team as a code owner December 5, 2023 19:55
@nrobinaubertin nrobinaubertin merged commit 316a818 into main Dec 6, 2023
28 checks passed
@nrobinaubertin nrobinaubertin deleted the proxy branch December 6, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants