Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make the artifact download workflow step less dependent on build workflow name #174

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

locnnil
Copy link
Contributor

@locnnil locnnil commented Aug 26, 2024

Remove workflow optional argument and set workflow_search to true, so the artifact can be matched based on the other given characteristics.

@locnnil locnnil requested a review from farshidtz August 26, 2024 10:36
Signed-off-by: Lincoln Wallace <[email protected]>
@locnnil locnnil force-pushed the improve-download-artifact branch from 2b6bf47 to 376d457 Compare August 26, 2024 10:54
Signed-off-by: Lincoln Wallace <[email protected]>
@locnnil locnnil requested a review from farshidtz August 26, 2024 11:26
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Resolving to #170 (comment) and #170 (comment)

@farshidtz farshidtz changed the title feat: remove optional argument to make less dependent on filename ci: Make the artifact download workflow step less dependent on build workflow name Aug 26, 2024
@farshidtz farshidtz merged commit 6e33ea2 into canonical:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants