add: utility script to upgrade docker-snap version #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It works by running it from the base root of the project: ``` ./.github/workflows/upgrade.sh ``` It generates the necessary changes on snap/snapcraft.yaml by fetching the latest version available for Moby using the GitHub api. And then based on the Dockerfile for the latest version, it fetches the necessary tags for the other parts of docker-snap. It only changes the needed code and not the comments. Signed-off-by: Lincoln Wallace <[email protected]>
farshidtz
requested changes
Dec 16, 2024
Signed-off-by: Lincoln Wallace <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
farshidtz
requested changes
Dec 16, 2024
Signed-off-by: Lincoln Wallace <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
* helper to check if yq is present.
* helper to check the need of update.
* replace all occurencies of the old engine version
for the new one in the comments.
Signed-off-by: Lincoln Wallace <[email protected]>
farshidtz
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It generates the necessary changes on
snap/snapcraft.yamlby fetching the latest version available for Mobyusing the GitHub API.
And then, based on the Dockerfile for the latest version, it fetches the necessary tags for the other parts of docker-snap.
It also updates the comments with the new version for the Moby Engine.
PS: It has well known that the script generates some undesired changes like: It deletes the blank lines on the
snap/snapcraft.yamlfile, this is because of howyqbehaves (since it serializes and deserializes theYAMLfile). And it's not something that I'm willing to fix on this script with this PR. The undesired changed can be removed by doinggit restore snap/snapcraft.yaml -pand selecting the changes that you want to discard. Or also by doinggit add -pand adding to the stage area only the changes that you want and discarding the other ones withgit restore ..