update test to reflect next_url in redirection

canonical · Feb 6, 2024 · 225423c · 225423c
1 parent a938ed4
commit 225423c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/flask_multipass_saml_groups/provider.py b/flask_multipass_saml_groups/provider.py
@@ -5,7 +5,6 @@
 import operator
 from datetime import datetime, timedelta, timezone
 from typing import Dict, Iterable, Optional, Type
-from urllib.parse import urlsplit
 
 from flask import current_app, redirect, request, session, url_for
 from flask_multipass import (

diff --git a/tests/unit/test_provider.py b/tests/unit/test_provider.py
@@ -485,9 +485,11 @@ def test_redirect_to_login_if_session_expired(app, client):
     with client.session_transaction() as sess:
         sess[EXPIRY_SESSION_KEY] = dt_now - timedelta(seconds=1)
 
-    resp = client.get("/sample")
+    next_url = "/sample"
+    resp = client.get(next_url)
     assert resp.status_code == 302
-    assert resp.location == url_for(app.config["MULTIPASS_LOGIN_ENDPOINT"])
+    assert url_for(app.config["MULTIPASS_LOGIN_ENDPOINT"]) in resp.location
+    assert next_url in resp.location
 
 
 @freeze_time("Jan 14th, 2024")