-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial functionality #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 36 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
24 | 1 | 11 | 0 |
Click to see the invalid file list
- flask_multipass_saml_groups/migrations/20230725_1640_ae387f5fc14a_initial_migration.py
flask_multipass_saml_groups/migrations/20230725_1640_ae387f5fc14a_initial_migration.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit eca8641.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing docstrings for a few methods - are there plans to add those later or is that something that could be addressed now?
Any missing docstrings should be docstrings equivalent to the base class docstring. I avoided copy & paste there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks. And thanks for the thorough PR description.
This PR adds the basic functionality to support the SAML group attributes using Flask Multipass within Indico.
The current SAML Identity Provider in Flask Multipass does not support the SAML group attributes, see this issue for further explanation.
Implementation notes:
SQLAlchemy
instance from the Indico package, but this could be extended to be independent of Indico to be used for other services.