-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to connect to Leader via all known servers simultaneously #290
Conversation
@cole-miller @MathieuBordere This PR may pass the tests as-is but would love feedback on the importance of batching. I will admit I have no idea how large these clusters can be. Reading through the comments on #134, it seems like I either
|
Sorry for the delay. Re: batching and prioritization, how would you feel about this:
(@MathieuBordere does this look reasonable to you?) |
@cole-miller I agree with most of this. I think it could be just a little simpler, and also more reflective of the original logic.
|
Thanks, I think you're right and that's a better plan! It nicely sidesteps the issue of how to prioritize candidates that were generated by asking some server over those taken from the a priori sorted list. |
@cole-miller this was great feedback. Thanks for taking the time to create it. Looking forward to implementing these changes |
Will close in favor of #292 |
Resolves #134
Inspecting the result of this change may be easier than reading the diff as a first pass.
Summary
Design choices