Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new snapshot trailing strategy parameter #361

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Feb 10, 2025

This PR adds the capability to set the new strategy parameter for trailing entries computation.

In case the API is not there (because of an old library linked) it will still accept settings with "STATIC" as that's the old behaviour. Trying to set "DYNAMIC" behaviour on old libraries will result in an error.

@marco6 marco6 force-pushed the new-snapshot-parameter branch from 2a56a32 to 920dae7 Compare February 10, 2025 10:10
@marco6 marco6 changed the title New snapshot parameter feat: new snapshot trailing strategy parameter Feb 10, 2025
Copy link

@just-now just-now left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco6 marco6 force-pushed the new-snapshot-parameter branch from 920dae7 to 12a8791 Compare February 13, 2025 11:05
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Marco!

@marco6 marco6 merged commit 767b023 into canonical:v3 Feb 13, 2025
9 checks passed
@marco6 marco6 deleted the new-snapshot-parameter branch February 13, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants