Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status, bundle probes #213

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Add status, bundle probes #213

merged 4 commits into from
Jan 24, 2025

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Nov 22, 2024

NOTE: this PR is not intended to be merged yet!

Issue

Need a quick way to determine if grafana-agent deployment is correct.

Solution

Add a few external probes, runnable against a bundle or a status.

Context

https://discourse.charmhub.io/t/how-to-testing-cos-integrations/14532

Testing Instructions

Per committed README.

@sed-i sed-i changed the title Add probes Add probes (WIP) Nov 22, 2024
@sed-i sed-i marked this pull request as ready for review January 24, 2025 18:39
@sed-i sed-i requested a review from a team as a code owner January 24, 2025 18:39
@sed-i sed-i changed the title Add probes (WIP) Add status, bundle probes Jan 24, 2025
Signed-off-by: Leon <[email protected]>
Copy link
Contributor

@MichaelThamm MichaelThamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, can merge because the changes are unrelated to flaky CI

@MichaelThamm MichaelThamm merged commit 11eab4d into main Jan 24, 2025
11 of 12 checks passed
@MichaelThamm MichaelThamm deleted the feature/probes branch January 24, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants