Remove log pollution from charm tracing in scenario tests #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In scenario test runs, a significant number of warnings (and some error logs) came from the fact that charm tracing was enabled even though there isn't anything charm traces can be sent to.
Solution
Disable charm tracing in all scenario tests as we aren't testing charm tracing there. We're testing tracing-related configuration in one set of tests, but this doesn't need charm tracing to be enabled.
Context
Testing Instructions
Run
tox -e scenario
and see the log pollution decreased significantly.Upgrade Notes