Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permissions in created files #239

Merged
merged 9 commits into from
Jan 22, 2025
Merged

fix: permissions in created files #239

merged 9 commits into from
Jan 22, 2025

Conversation

lucabello
Copy link
Contributor

@lucabello lucabello commented Jan 17, 2025 •
edited by sed-i
Loading

@lucabello lucabello requested a review from a team as a code owner January 17, 2025 15:43
@sudhackar
Copy link
Member

@canonical/seceng-psirt

LGTM

Had some discussion on mm :)

@sudhackar
Copy link
Member

umask is a shell built-in.

You use os.umask - which would be more pythonic?

@lucabello
Copy link
Contributor Author

Good point, that also makes it easier to handle the failing tests :)

@lucabello lucabello merged commit 5e618e7 into main Jan 22, 2025
12 checks passed
@lucabello lucabello deleted the fix/umask branch January 22, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbraAoad IbraAoad IbraAoad approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucabello @sudhackar @IbraAoad