Fix Grafana Agent Node Exporter Quickstart dash

[samuelallan72]

• Use the prometheus datasource variable as expected by the COS tools.
• Remove the old instance and job filter variables:
  • instance is a long generated string; use juju_unit instead (and not a multi-select for juju_unit, as this dashboard is designed to be used on one instance at a time)
  • job is also long and generated so we can't hard code it any more

Screenshots:

Before:

After:

Fixes #24

[samuelallan72]

I don't know why there is a duplicate grafana_dashboards/ directory - I edited the one in src/grafana_dashboards, which seems to be the one that is used by the charm. The charm appears to simply copy src/grafana_dashboards to ./grafana_dashboards, so maybe the grafana_dashboards dir doesn't get built into the charm? Can we delete it from the git repo to avoid confusion?

[simskij]

I don't know why there is a duplicate grafana_dashboards/ directory - I edited the one in src/grafana_dashboards, which seems to be the one that is used by the charm. The charm appears to simply copy src/grafana_dashboards to ./grafana_dashboards, so maybe the grafana_dashboards dir doesn't get built into the charm? Can we delete it from the git repo to avoid confusion?

From what I can tell there is no such folder in the repo, not here nor in your fork. Am I missing something? If not, I'm ok with having this merged.

[samuelallan72]

@simskij ah my bad, it was there for me locally, but must have been generated by something; I looked just now, and it wasn't checked into git. you can ignore that comment. :)

[sed-i]

@simskij ah my bad, it was there for me locally, but must have been generated by something; I looked just now, and it wasn't checked into git. you can ignore that comment. :)

It's generated by utests.

[sed-i]

Looks good @samuelengineer!
Could you please paste a screenshot in the PR description showing how the dashboard looks without the job and instance label matchers?

[samuelallan72]

@sed-i happy new year! PR description updated with screenshots. :)

[lucabello]

@sed-i can this be merged? :)