add optional secureJsonData to grafana datasources #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #295.
Some datasources, like Mimir, need custom HTTP Headers to be specified in the datasource configuration.
As seen here, header names can be specified under
jsonData
, which we currently build from theextra_data
parameter in theGrafanaSourceProvider
constructor.However, the value for a header must be specified under
secureJsonData
, which we currently don't allow to specify in thegrafana_source
library.Solution
This PR adds an optional
secure_extra_data
constructor argument, right next toextra_data
, so that we can (in the same fashion asjsonData
) specifysecureJsonData
for a datasource.