Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken panel in the main dashboard #345

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

lucabello
Copy link
Contributor

@lucabello lucabello commented Aug 6, 2024

Issue

Closes #343.

(and fixes the broken ruff usage).

Solution

Use $__rate_interval instead of $__interval.

You can see the panel now has data:
Screenshot-2024-08-06_14-30

Testing Instructions

charmcraft pack
juju deploy <grafana-charm> <resources> grafana
juju deploy prometheus

juju relate grafana:metrics-endpoint prometheus
juju relate grafana:grafana-source prometheus

Open some pages in Grafana, wait for a few scrapes, then look at the dashboard :)

@lucabello lucabello requested a review from a team as a code owner August 6, 2024 12:30
@lucabello
Copy link
Contributor Author

The charm now packs; integration tests need to be re-run until they pass 🫠

@lucabello
Copy link
Contributor Author

Note that I'm disabling the oauth test because they started failing on timeout with no reason (they passed on main and this PR only touched a dashboard file).

@lucabello lucabello merged commit 1c80f74 into main Aug 12, 2024
13 checks passed
@lucabello lucabello deleted the fix/broken-panel-self-dashboard branch August 12, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken panel in the main dashboard
2 participants