-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically overwrite dashboard UIDs with a prescribed naming pattern, on the provider side #363
Draft
sed-i
wants to merge
14
commits into
main
Choose a base branch
from
feature/uid-collision
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd appreciate your review, @Guillaumebeuzeboc, @taurus-forever, @jdkandersson, @cbartz, @camille-rodriguez, @slapcat, @facundofc. |
I'll delegate to @cbartz who has the best understanding of the issue in our team, thank you for preparing the PR! |
sed-i
force-pushed
the
feature/uid-collision
branch
from
December 20, 2024 22:37
6acd42e
to
64ddc56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Use shake_256 to generate alt-uid, and always use it, overwriting any pre-existing uid.
In tandem with:
Context
Afaict, the only user of the
.add_dashboard
method is https://github.com/canonical/cos-registration-server-k8s-operator/blob/6e156f0b1367f7cc6ce12d89f6a367bf491fea7f/src/charm.py#L240.Testing Instructions
First, prepare the charms locally:
--hash
from requirements.txt:Upgrade Notes
To enable automatic uid collision prevention for the dashboards in your charm: