Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add show-unit probes #381

Merged
merged 8 commits into from
Jan 28, 2025
Merged

feat: add show-unit probes #381

merged 8 commits into from
Jan 28, 2025

Conversation

MichaelThamm
Copy link
Contributor

@MichaelThamm MichaelThamm commented Jan 22, 2025

Issue

If dashboards do not have a valid UID in relation data, they will not be rendered in Grafana.

Solution

External probe for checking dashboard UIDs over relation data. Checking for:

  • Not empty
  • Valid format

Context

This probe relies on a juju show-unit grafana/0 input. Therefore it was places in the probes/show-unit dir.

Testing Instructions

juju deploy cos-lite --trust
juju show-unit grafana/0 | ./probes/show-unit/relation_dashboard_uid.py

Upgrade Notes

@lucabello lucabello changed the title Add probes (WIP) feat: Add probes (WIP) Jan 23, 2025
@lucabello lucabello changed the title feat: Add probes (WIP) feat: add probes (WIP) Jan 23, 2025
@MichaelThamm MichaelThamm marked this pull request as ready for review January 24, 2025 19:57
@MichaelThamm MichaelThamm requested a review from a team as a code owner January 24, 2025 19:57
@MichaelThamm MichaelThamm changed the title feat: add probes (WIP) Add show-unit probes Jan 24, 2025
@lucabello lucabello changed the title Add show-unit probes feat: add show-unit probes Jan 27, 2025
@MichaelThamm MichaelThamm merged commit 3c8db2d into main Jan 28, 2025
13 checks passed
@MichaelThamm MichaelThamm deleted the feature/probes branch January 28, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants