Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

[func] fix zaza overlays #61

Merged
merged 4 commits into from
Jan 27, 2022
Merged

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Jan 24, 2022

remove --test-directory from tox.ini

This is due to the bug 1 that indicates that overlays can only be used if
they are placed in ./tests/overlays subdirectory.

These changes was tested with following overlay

# ceph.yaml.j2
series: focal

This is due to the bug [1] that indicates that overlays can only be used if
they are placed in ./tests/overlays subdirectory.

---
[1]: openstack-charmers/zaza#475
@rgildein rgildein added the bug Something isn't working label Jan 24, 2022
@rgildein rgildein requested a review from auria January 24, 2022 16:50
@rgildein rgildein self-assigned this Jan 24, 2022
@auria auria requested review from mkalcok and removed request for auria January 26, 2022 11:31
mkalcok
mkalcok previously approved these changes Jan 26, 2022
Copy link
Contributor

@mkalcok mkalcok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recheck-full

Copy link
Contributor Author

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recheck-full

@rgildein rgildein requested a review from mkalcok January 27, 2022 13:47
@rgildein rgildein merged commit c43dfa4 into canonical:master Jan 27, 2022
@rgildein rgildein deleted the func/fix-zaza-overlays branch January 27, 2022 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants