ci: use cache built charms in bundle tests #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NohaIhab
commented
Jan 28, 2025
Comment on lines
+90
to
+103
| update_charm_context(context, charm, cached_charm) | ||
| # Otherwise build the charms with ops_test | ||
| else: | ||
| charms_to_build = { | ||
| charm: Path(CHARM_PATH_TEMPLATE.format(basedir=str(basedir), charm=charm)) | ||
| for charm in KFP_CHARMS | ||
| } | ||
| log.info(f"Building charms for: {charms_to_build}") | ||
| built_charms = await ops_test.build_charms(*charms_to_build.values()) | ||
| log.info(f"Built charms: {built_charms}") | ||
|
|
||
| for charm, charm_file in built_charms.items(): | ||
| charm_resources = get_resources_from_charm_file(charm_file) | ||
| context.update([(f"{charm.replace('-', '_')}_resources", charm_resources)]) | ||
| context.update([(f"{charm.replace('-', '_')}", charm_file)]) | ||
|
|
||
| # Build charms sequentially | ||
| for charm_name, charm_path in charms_to_build.items(): | ||
| log.info(f" Building charm {charm_name}") | ||
| built_charm = await ops_test.build_charm(charm_path) | ||
| update_charm_context(context, charm_name, built_charm) |
There was a problem hiding this comment.
The local build will now be different from the CI because it's using charmcraft, as opposed to the CI using charmcraftcache. We could approach this by telling developers to pack the charms with charmcraftcache locally before running the tests and passing --charms-path, although I can see the prerequisite being a bit annoying. WDYT @DnPlas ?
There was a problem hiding this comment.
We could have this information on the integration tests README.md. I wouldn't consider it a pre-requisite, but an option:
## Testing locally
Option A - Build charms with charmcraft
<test instructions and a tiny explanation of what's happening>
Option B - Build charms with ccc
<test instructions and a tiny explanation of what's happening>
<tox -ve integration -- --charms-path >
DnPlas
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654
This PR deprecates the
--no-buildoption, that was used to deploy the charms from Charmhub and test them locally due to it not being used by the team.Summary
--charms-pathparameter to pass to integration testsNote to reviewer:
the single charm integration tests are failing due to canonical/kubeflow-ci#152, this should be fixed by #663