Skip to content

Commit

Permalink
github: more elegantly report image-test failures
Browse files Browse the repository at this point in the history
Previously, a failure from `./bin/test-image` would abort immediatly due to
`set -e`. Now, we get a chance of echo'ing that it failed.

Signed-off-by: Simon Deziel <[email protected]>
  • Loading branch information
simondeziel committed May 2, 2024
1 parent 9d88f28 commit 245ea90
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/actions/image-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,10 @@ runs:
exit 1
fi
./bin/test-image "${TYPE}" "${DISTRO}" "${RELEASE}" "${VARIANT}" "${TARGET}"
if [ "$?" = "0" ]; then
if ./bin/test-image "${TYPE}" "${DISTRO}" "${RELEASE}" "${VARIANT}" "${TARGET}"; then
echo "==> PASS: ${TEST_ID}"
exit 0
fi
echo "==> FAIL: ${TEST_ID}"
exit 0
exit 1

0 comments on commit 245ea90

Please sign in to comment.